Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard should show TaskRun sidecars + their logs #972

Open
bitsofinfo opened this issue Jan 28, 2020 · 18 comments
Open

Dashboard should show TaskRun sidecars + their logs #972

bitsofinfo opened this issue Jan 28, 2020 · 18 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@bitsofinfo
Copy link

bitsofinfo commented Jan 28, 2020

Dashboard should show TaskRun sidecars + their logs

@bitsofinfo bitsofinfo changed the title Dashboard should show TaskRun sidecards + their logs Dashboard should show TaskRun sidecars + their logs Jan 28, 2020
@AlanGreene AlanGreene added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 29, 2020
@a-roberts
Copy link
Member

Yeah, this sounds like a great addition, asked @vdemeester for an example and https://github.com/tektoncd/pipeline/blob/master/examples/taskruns/dind-sidecar.yaml looks suitable for working with

@tekton-robot
Copy link
Contributor

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Send feedback to tektoncd/plumbing.

@tekton-robot
Copy link
Contributor

@tekton-robot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Send feedback to tektoncd/plumbing.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@AlanGreene
Copy link
Member

/reopen

@tekton-robot
Copy link
Contributor

@AlanGreene: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@AlanGreene
Copy link
Member

I think it would be a good idea to consider this along with #572 and #1445 to ensure we provide a good experience and don't introduce too many different mechanisms for accessing errors / logs.

@AlanGreene
Copy link
Member

This might also benefit from some of the updates being made for #1775.

@tekton-robot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 15, 2021
@bitsofinfo
Copy link
Author

/remove-lifecycle stale

@tekton-robot tekton-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 16, 2021
@tekton-robot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 17, 2021
@wingyplus
Copy link
Contributor

Hi, may I know what to do with this issue? I’ve some free time to work on this issue. :)

@bitsofinfo
Copy link
Author

/remove-lifecycle stale

@tekton-robot tekton-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 11, 2021
@AlanGreene
Copy link
Member

AlanGreene commented Jun 11, 2021

This should have been linked to #1445 which we'll need to tackle first, it was already mentioned above but I've just added it as a blocker now.

There are a number of closely related issues that require us to revisit how we structure and display the Task / step / log details so it all works as users expect without over-complicating the code. You can see some of the discussion in #1445 and the other linked issues above. Any proposals on this are welcome, and we can discuss them in more detail before implementation.

@AlanGreene
Copy link
Member

freezing this so it doesn't get auto-closed since this is something we do want to add

/lifecycle frozen

@tekton-robot tekton-robot added the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Jun 11, 2021
@wingyplus
Copy link
Contributor

Thanks for your information. Let me catchup with those issues first. :)

@shinji62
Copy link

@AlanGreene Any update on this one ? We will need to do that too, and not sure how Tekton Dashboard is going to handle that.

@wingyplus
Copy link
Contributor

@shinji62 Currently it's still blocking by #1445. I've worked on color on that issue but I've no time to look it more on that issue at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
Status: Todo
Development

No branches or pull requests

6 participants