Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PipelineRun/TaskRun YAML view #762

Open
ncskier opened this issue Nov 20, 2019 · 13 comments
Open

PipelineRun/TaskRun YAML view #762

ncskier opened this issue Nov 20, 2019 · 13 comments
Assignees
Labels
kind/design Categorizes issue or PR as related to design. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@ncskier
Copy link
Member

ncskier commented Nov 20, 2019

Expected Behavior

When my PipelineRun/TaskRun has an error like a validation error, I would like to be able to view the YAML of the PipelineRun/TaskRun to debug.

Actual Behavior

There is no way to view the entire YAML for a PipelineRun or TaskRun. Only Tasks and Pipelines have a YAML view at the moment.

@AlanGreene
Copy link
Member

AlanGreene commented Nov 20, 2019

Giving users the ability to view the raw YAML would definitely be useful, but we should also consider whether there are other/better ways to surface important info like this in the UI.

We could add a link on the list views to our generic YAML page like we have on the Pipelines and Tasks views, could even do this from the PipelineRun / TaskRun details page, but it feels like cheating and that approach was supposed to be a very short term thing.

@kimholmes do we have designs for showing the raw Tekton YAML anywhere in the recent updates? I know we discussed it briefly but can't remember if we documented it anywhere.

@kimholmes
Copy link

@AlanGreene The only place we're surfacing the YAML in the designs is on the Service Accounts. But we can certainly add this capability. Happy to discuss.

@vdemeester
Copy link
Member

/kind bug

@tekton-robot tekton-robot added the kind/bug Categorizes issue or PR as related to a bug. label Nov 26, 2019
@kimholmes
Copy link

@AlanGreene I'm interested to learn more about what you mean when you say that surfacing the YAML feels like cheating. Why was that approach supposed to be a short term thing?
Another question. Is it easy to link out to the YAML on Github?

@AlanGreene
Copy link
Member

The way we did it for Tasks and Pipelines was meant to be a short term thing, it was never meant to be the only view for those resources. We have detail views for all other resource types, but for those two we either link to a filtered list of TaskRuns or PipelineRuns associated with the selected resource, or show the raw YAML. There's no page showing a more user-friendly rendering of a single resource.

There's no reliable way to determine where the YAML came from, it could have been manually created and applied to the cluster, could be from our Import feature, or applied in any other number of ways, so we can't guarantee there's an external location we can link to.

@AlanGreene AlanGreene added kind/feature Categorizes issue or PR as related to a new feature. and removed kind/bug Categorizes issue or PR as related to a bug. labels Nov 26, 2019
@kimholmes
Copy link

@AlanGreene Ok. That makes sense. If we want to be consistent with what we're doing in other parts of the design for the UI, we'd add a YAML tab on the Details view. So, there would be a Details tab and a YAML tab.
image
image

However, we should be strategic about it as well. If there is an error in the Run, can we link directly to the part of the YAML that contains the error? Or do we have to link to the YAML as a whole?

@tekton-robot
Copy link
Contributor

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

@tekton-robot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.

/lifecycle stale

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 13, 2020
@AlanGreene
Copy link
Member

/remove-lifecycle rotten
/remove-lifecycle stale

@tekton-robot tekton-robot removed lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 13, 2020
@AlanGreene
Copy link
Member

This issue is still valid. We need to revisit the proposed designs to take into account recent additions to Pipelines and Triggers and determine a sensible way to connect resources from these two projects in the UI. The outcome of that review may have some impact on the 'Details' tab, but the YAML view is still useful and should be added for consistency with other resource types that already have this functionality in the Dashboard.

@AlanGreene
Copy link
Member

/kind design

@tekton-robot tekton-robot added the kind/design Categorizes issue or PR as related to design. label Nov 10, 2020
@tekton-robot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 8, 2021
@AlanGreene
Copy link
Member

This is still something we want to do. Freezing to prevent it from auto-closing
/lifecycle frozen

@tekton-robot tekton-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/design Categorizes issue or PR as related to design. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
Status: Todo
Development

No branches or pull requests

5 participants