Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update React Router to v6 #2452

Open
AlanGreene opened this issue Sep 9, 2022 · 6 comments
Open

Update React Router to v6 #2452

AlanGreene opened this issue Sep 9, 2022 · 6 comments
Assignees
Labels
area/dependency Issues or PRs related to dependency changes kind/misc Categorizes issue or PR as a miscellaneuous one. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@AlanGreene
Copy link
Member

AlanGreene commented Sep 9, 2022

Update react-router / react-router-dom to the v6 releases. This will likely be a breaking change for consumers of the Dashboard's @tektoncd/dashboard-components and @tektoncd/dashboard-utils packages and will need to be managed carefully.

See the documentation for details of the changes:
https://reactrouter.com/en/main/upgrading/v5

There is a compatibility layer that should make the update process a bit smoother, allowing us to use both APIs in parallel while we make the required changes across the app, although it may not cover all use cases. This is documented at:
remix-run/react-router#8753

Some changes have already been done in preparation for this update:

Some additional changes identified:

  • Link component prop is no longer supported in v6, useHref hook in custom component instead
  • When updating search params, useSearchParams instead of current manual URLSearchParams and history.push approach. Not 'required' but is a nice cleanup that we should consider

Once we agree a timeline for this update the next steps will be to review the latest documentation, enable the compatibility layer, and start by updating a small set of routes to validate the process.

@AlanGreene AlanGreene added kind/feature Categorizes issue or PR as related to a new feature. area/dependency Issues or PRs related to dependency changes kind/misc Categorizes issue or PR as a miscellaneuous one. labels Sep 9, 2022
@AlanGreene AlanGreene self-assigned this Sep 9, 2022
@AlanGreene AlanGreene removed the kind/feature Categorizes issue or PR as related to a new feature. label Sep 9, 2022
@AlanGreene
Copy link
Member Author

Recent React Router v5 releases have some fixes for React 18 compatibility so we should try updating React first and see how that goes.

Our previous attempt at updating React Router using the compatibility layer ran into some issues but with most other dependencies now updated, and assuming the React 18 update works as expected, it's time to try this again.

If the compatibility layer doesn't work out we can just update it all in one go but it would be nice to break it down into a series of smaller changes if possible to facilitate easier review and testing.

@AlanGreene
Copy link
Member Author

AlanGreene commented Oct 21, 2022

PR #2542 opened to add the compatibility layer and start migrating to the new API. All routes have been converted to use the compatibility layer, including hooks from the new API.

Remaining:

  • convert <Route children> to <Route element>
    • header already using this approach and working as expected, only minor inconvenience was that the children render prop approach is no longer supported to always render content whether the path matches or not. Instead we duplicate the route (as recommended in the docs) including a 'splat' (wildcard) for any unmatched paths to ensure it always renders even when on a non-namespaced path.
  • <Switch> becomes <Routes>
    • remove exact prop on routes
  • updates for <Link> to address the component prop issue
  • optional: useSearchParams instead of current manual approach using URLSearchParams etc.

@AlanGreene
Copy link
Member Author

/lifecycle frozen
Freezing so it doesn't get auto-closed due to inactivity. This is a longer term item that's currently blocked on the move to React 18, Carbon 11, and related changes.

@tekton-robot tekton-robot added the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Jan 3, 2023
@AlanGreene
Copy link
Member Author

Revisiting this in the near future. According to the declared dependencies we should actually be able to upgrade to React Router v6 while remaining on React 17. Perhaps some of the previous issues were red herrings or have since been resolved 🤞

$ npm show react-router-dom version
6.8.1
$ npm show react-router-dom@6.8.1 peerDependencies
{ react: '>=16.8', 'react-dom': '>=16.8' }

@AlanGreene
Copy link
Member Author

Last PR related to compatibility layer issues: #2650
May be resolved now

@AlanGreene
Copy link
Member Author

I've been looking at a large set of updates across our main dependencies. There are a number of improvements in React Router 6 that allow us to remove previous workarounds / custom components that were added purely for managing / interacting with the router, in favour of built-in APIs now provided by RR.

These allow us to significantly simplify the client architecture, reduce maintenance overhead, and further lower the barrier to entry for new contributors. As a result it also makes some previously explored feature requests more feasible.

More to come after our next LTS release is done so we can focus more effort on these upgrades.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependency Issues or PRs related to dependency changes kind/misc Categorizes issue or PR as a miscellaneuous one. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
Status: Todo
Development

No branches or pull requests

2 participants