Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for array parameters in the Create TaskRun and Create PipelineRun pages #2171

Open
torrescd opened this issue Aug 13, 2021 · 6 comments
Labels
area/roadmap Issues that are part of the project (or organization) roadmap (usually an epic) kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@torrescd
Copy link

torrescd commented Aug 13, 2021

Is your feature request related to a problem ?

Imposible to enter/change an array parameter through UI.

All input changes seems to be transformed to string. (Default untouched arrays work well)

Describe the solution you'd like

Some way to enter/change an array parameter

Describe alternatives you've considered

Additional context

Steps to see current behaviour (array parameters converted to string)

  • Task with array parameter
  • Change default value
  • Create taskrun
@torrescd torrescd added the kind/bug Categorizes issue or PR as related to a bug. label Aug 13, 2021
@torrescd torrescd changed the title Imposible to enter/change an array parameter thought UI Imposible to enter/change an array parameter through UI Aug 13, 2021
@AlanGreene
Copy link
Member

Thanks for opening this issue @torrescd. I'm converting it to a feature request since it's not something we've supported in any Dashboard release so far but would be a good addition.

There are a number of ways we could present this in the Create PipelineRun / TaskRun UI.
Some initial thoughts:

  1. a simple textarea where each array item is entered on a separate line
  2. similar to the labels / node selector fields where we present a list of text inputs and buttons to add / remove them as needed
  3. something else?

Do you have any thoughts on how you would expect to be able to enter them?

Can you provide some examples of how you're using array parameters in your Tasks?

@AlanGreene AlanGreene added kind/feature Categorizes issue or PR as related to a new feature. and removed kind/bug Categorizes issue or PR as related to a bug. labels Aug 13, 2021
@AlanGreene AlanGreene changed the title Imposible to enter/change an array parameter through UI Add support for array parameters in the Create TaskRun and Create PipelineRun pages Aug 13, 2021
@torrescd
Copy link
Author

Thank you for consider the request.

Maybe another possibility to process the array value always as a yaml array, able to be parsed. e.g.

["value","anotherValue"]

- a
- b

[] null empty?

Currently, when the default value is displayed is showing a comma-separated list, but is not able to be parsed if you enter a new list, maybe this list format working is another option.

Regards!

@tekton-robot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 11, 2021
@AlanGreene
Copy link
Member

We still want this, freezing so it doesn't get auto-closed.
/lifecycle frozen

@tekton-robot tekton-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Nov 12, 2021
@AlanGreene AlanGreene added this to the v0.29 milestone Aug 11, 2022
@AlanGreene AlanGreene removed this from the v0.29 milestone Jan 5, 2023
@AlanGreene
Copy link
Member

This is currently supported on the Create PipelineRun page via the recently added YAML mode.
Create TaskRun will get the same treatment in the near future.

It would still be great to have this functionality in the form-based UI too for ease of use so keeping the issue open.

@AlanGreene
Copy link
Member

/area roadmap

@tekton-robot tekton-robot added the area/roadmap Issues that are part of the project (or organization) roadmap (usually an epic) label Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/roadmap Issues that are part of the project (or organization) roadmap (usually an epic) kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
Status: Todo
Development

No branches or pull requests

3 participants