Return value of tkn pipeline start with --showlog does not depend on state of started pipeline

[anetbnd]

Versions and Operating System

• Kubernetes version:

Server Version: version.Info{Major:"1", Minor:"24", GitVersion:"v1.24.6+5157800", GitCommit:"eddac29feb4bb46b99fb570999324e582d761a66", GitTreeState:"clean", BuildDate:"2022-10-11T13:02:03Z", GoVersion:"go1.18.7", Compiler:"gc", Platform:"linux/amd64"}

• Tekton Pipeline version:

  Output of tkn version or kubectl get pods -n tekton-pipelines -l app=tekton-pipelines-controller -o=jsonpath='{.items[0].metadata.labels.version}'

Client version: 0.24.1
Pipeline version: v0.37.5
Triggers version: v0.20.2
Operator version: v0.60.1

• Operating System:

Linux

Expected Behavior

When I run a pipeline with tkn pipeline start <pipeline-name> --showlog and the pipeline fails, I expect the return value of the tkn command is also non 0. In this way it is possible to start a pipeline from another pipeline and fail the first one, if the second one has failed.

Actual Behavior

The return value of tkn pipeline start <pipeline-name> --showlog is 0, if the started pipeline fails.

Steps to Reproduce the Problem

1. tkn pipeline start <pipeline-name> --showlog || echo "run failed"

The "run failed" string is never shown, even if the started pipeline failed.

Additional Info

...

[avinal]

/assign

[tekton-robot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

[avinal]

/remove-lifecycle stale Work in Progress

[tekton-robot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

[anetbnd]

/remove-lifecycle rotten Please don't give up the implementation here, it is an important feature for us!

[avinal]

Looks like I need some help here. Apology for delay. I will start working again.

[tekton-robot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen with a justification.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

[tekton-robot]

@tekton-robot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen with a justification.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[anetbnd]

/reopen This is a really important feature in order to trigger a pipeline from another pipeline. Please don't let it die!

[anetbnd]

/remove-lifecycle rotten This is a really important feature in order to trigger a pipeline from another pipeline. Please don't let it die!

[avinal]

I have asked for help on the channel, so far, there is no significant progress.

[ileixe]

+1 for this feature to use tkn cli for CI runner. Now, it's completely inconsistent just to rely on "tkn start --showlog" for the job. We're very happy to have this.

[avinal]

/reopen

[tekton-robot]

@avinal: You can't reopen an issue/PR unless you authored it or you are a collaborator.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tekton-robot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen with a justification.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

[tekton-robot]

@tekton-robot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen with a justification.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[anetbnd]

/reopen Please don't forget this issue here. It is not solved yet but very important for triggering tekton pipelines from other pipelines.

[anetbnd]

/remove-lifecycle rotten Please don't forget this issue here. It is not solved yet but very important for triggering tekton pipelines from other pipelines.

[avinal]

/reopen

[tekton-robot]

@avinal: You can't reopen an issue/PR unless you authored it or you are a collaborator.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tekton-robot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen with a justification.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

[tekton-robot]

@tekton-robot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen with a justification.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[anetbnd]

Please do not close this. It is a very important feature. Without this feature, it is not possible to start a pipeline from another pipeline and track the state.

[ileixe]

Hi @avinal , can I try your branch? Is it completed?

[avinal]

Hi @avinal , can I try your branch? Is it completed?

Hey @ileixe, yes the fix is completed and tested manually but I couldn't figure out the tests and got busy elsewhere. Please feel free to continue. Thank You

[ileixe]

Ok, I will give it a try. Let me update if there's any problem. Thanks.

[ileixe]

@avinal Unfortunately, code have subtle bug now. It checks right after pod log tailing, but status of PipelineRun can be not updated until then.

I think we may have to add small loop to check PR is actually completed, but not sure it's completely safe. Let me give a shot.

It seems actually not working at all, as status field is is not fetched via API. (I was confused since the failed task emits non-zero after the change, but it was always failed.) I'm not sure it's right approach but we may have to call API (not local view) to check status.

[ileixe]

PR updated: #2155

It ran as expected from our simple cases.

[piyush-garg]

@avinal This seems should be done with #2298 can you please check and close this