Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow calling votes as spectator in the client side #3214

Open
ChillerDragon opened this issue Sep 5, 2023 · 1 comment
Open

Allow calling votes as spectator in the client side #3214

ChillerDragon opened this issue Sep 5, 2023 · 1 comment

Comments

@ChillerDragon
Copy link
Contributor

Currently the client does not allow calling votes when being in the spectator team. Even if the server would allow it. And the server has no way of allowing it. Unless rcon authenticated the client will always remove the vote button in the menu if it is a spectator.

if(m_pClient->m_pVoting->IsVoting())
pNotification = Localize("Wait for current vote to end before calling a new one.");
else if(m_pClient->m_pVoting->CallvoteBlockTime() != 0)
{
str_format(aBuf, sizeof(aBuf), Localize("You must wait %d seconds before making another vote"), m_pClient->m_pVoting->CallvoteBlockTime());
pNotification = aBuf;
}
else if(!Authed && m_pClient->m_aClients[m_pClient->m_LocalClientID].m_Team == TEAM_SPECTATORS)
pNotification = Localize("Spectators aren't allowed to start a vote.");

In my opinion also vanilla should have a setting to allow and disallow voting as spectator in the settings. But for sure there should be an option for custom servers to make use of votes for spectators.

@ChillerDragon
Copy link
Contributor Author

Okay so there is the dead spec mode which can be used as a work around. But my argument stands for plain spectators. Polluting the scoreboard with dead tees to allow spectators to start votes is not optimal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant