Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New broadcast shadow looks horrible #2793

Closed
fokkonaut opened this issue Oct 27, 2020 · 5 comments · Fixed by #2805
Closed

New broadcast shadow looks horrible #2793

fokkonaut opened this issue Oct 27, 2020 · 5 comments · Fixed by #2805

Comments

@fokkonaut
Copy link
Contributor

fokkonaut commented Oct 27, 2020

The size got bigger and now it just looks awful...
image

comparing to an older client:
image

maybe the fade should be stronger and the shadow itself should get smaller again.

@SoulyVEVO
Copy link

i gotta agree, maybe making shadow more visible wasnt a bad idea by itself but this is too much

@TsFreddie
Copy link
Contributor

TsFreddie commented Oct 27, 2020

Looks like the server is using three lines with two empty lines. With one line it shouldn't look like that. We can make shadow fit the text horizontally as well.

But i'd say we should wait for the new textrender then we can just use the boundingbox.

Edit: plus we can make the gradient less aggressive with darker top and lighter bottom

@TsFreddie
Copy link
Contributor

TsFreddie commented Oct 27, 2020

We can also try to make shadow ignore empty lines.

Single line backdrop for reference
screenshot_2020-10-27_14-09-38

@Robyt3
Copy link
Contributor

Robyt3 commented Oct 27, 2020

You can try making it more transparent. I settled for this gradient because anything less dark is not as readable as it could be on some map backgrounds. Anything with a darker top makes the top edge or even the left or right edges explicitly visible to me, which I wanted to avoid.

Fade on the old client had almost no effect on readability and only gave you an indication that the broadcast was active at all.

I'm not sure if there is any way to make the gradient colored rounded corners not look weird with this size. IMO we could also get rid of this custom fade alltogether and just add a flat round rect with CORNER_T and correctly calculated size, if that looks better.

@l-ouis
Copy link

l-ouis commented Oct 29, 2020

both look bad imo, the gradient isn't very pretty. should rework it altogether

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants