Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible demos #2230

Closed
axblk opened this issue Sep 10, 2019 · 3 comments · Fixed by #2310
Closed

Incompatible demos #2230

axblk opened this issue Sep 10, 2019 · 3 comments · Fixed by #2310

Comments

@axblk
Copy link
Contributor

axblk commented Sep 10, 2019

The PR #2129 changed the format of the snapshots. For the client-server communication this does not matter, since the protocol only uses snapshot deltas.
The demos however, use complete snapshots for the keyframes, so the current master cannot play demos from 0.7.3, same for the other way round.

Solutions that come to my mind:

  1. Revert the PR
  2. Convert the snap format when loading and saving demos
  3. New demo format version
@Dune-jr
Copy link
Member

Dune-jr commented Sep 11, 2019

Right, that should be addressed before 0.7.4.

@LordSk
Copy link
Member

LordSk commented Nov 8, 2019

We could revert it for the time being. I'm not sure how to keep the changes with git though (and I don't have the original branch anymore).

Ideally we should have a demo format that does not depend heavily on a center piece structure of the game. So 2. and 3. at the same time.

@Dune-jr
Copy link
Member

Dune-jr commented Nov 8, 2019

From my point of view, the priority is to preserve the compatibility of demos between every 0.7.x version. It would be very confusing to explain to users which versions their demos are compatible with, especially when they're all mixed up in a folder :/

@oy oy closed this as completed in #2310 Dec 13, 2019
heinrich5991 pushed a commit to heinrich5991/teeworlds that referenced this issue Jun 19, 2020
2230: Fix grammar in ungrenade description (Thanks to Pipou) r=heinrich5991 a=def-



Co-authored-by: def <dennis@felsin9.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants