Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make room in the settings menus for additional options #1587

Open
Dune-jr opened this issue Oct 29, 2018 · 22 comments
Open

Make room in the settings menus for additional options #1587

Dune-jr opened this issue Oct 29, 2018 · 22 comments

Comments

@Dune-jr
Copy link
Member

Dune-jr commented Oct 29, 2018

Whenever I would like to add something in the settings menus, I feel like I have to do some sort of hack to merge it with an existing option.
Examples of options I feel could be added, to make already existing features easier to access:

More fantasies could include:

  • select game tiles

Any suggestion for changes? An additional tab? Sub-tabs?

@Zatline
Copy link
Member

Zatline commented Oct 29, 2018

you absolutly right i noticed that it's kinda difficult to add more options becouse of how everything is already taking all of the exiting space. It's a flaw in the UI design must admit.
I'll see what I can do to fix that and allow more options to be added easely, gotta restructure some panals.

@Dune-jr
Copy link
Member Author

Dune-jr commented Oct 30, 2018

What I would really love to see is an "Advanced" tab (or subtab) in the Settings where we could put stuff to make Teeworlds a bit more customisable without bloating the usual tabs.

@Dune-jr
Copy link
Member Author

Dune-jr commented Oct 31, 2018

For now, I'm thinking of just making two columns, like @LordSk already did in Graphics :

image

in General:

image

A more global solution could still be nice.

@LordSk
Copy link
Member

LordSk commented Oct 31, 2018

I respectfully strongly disagree with adding a lot more options to the game. Adding an option is the easy answer to issues that may come up. Giving responsibility to the user is not good design. Oh you don't like the background? Here is 10 options to change that, good luck. Why do we want a transparency slider for the UI? is the question we should ask ourselves and answer it. We can't please everybody, but pleasing most people is very doable.

That being said, splitting the screen in half like I did for the limit fps setting seems fine for now.
If it ever gets too crowded we can then think about re-designing settings menus like we are doing right now for the server browser.

@oy
Copy link
Member

oy commented Oct 31, 2018

Agree with @LordSk. We shouldn't bloat that stuff and focus on the stuff that's needed.

@Sonix-
Copy link
Member

Sonix- commented Oct 31, 2018

Divide the into 4 columns or boxes could be a solution.
Or adding sub-tabs (top or side aligned).

@Fisico
Copy link
Contributor

Fisico commented Oct 31, 2018

Why do we want a transparency slider for the UI? is the question we should ask ourselves and answer it. We can't please everybody, but pleasing most people is very doable.

Why not simply make the green background darker like the night background map and we dont need the slider.

@Dune-jr
Copy link
Member Author

Dune-jr commented Oct 31, 2018

The issue is the settings menu, not the background. Remember that the settings are also accessed ingame.

@1stDecadeTW
Copy link

Am I the only one who thinks the setting menu needs a revamp?

@Dune-jr
Copy link
Member Author

Dune-jr commented Nov 15, 2018

So there are several options that would be pretty cool to add, such as a Theme selector (#1675), or the Brightness slider for the UI (#1576) or even font options and what not we may come up with.

Often, it seems like those suggestions don't make consensus because they would increase the count of unnecessary options directly visible to the user (cf. @LordSk's comment just above). While I personally don't believe the menus are loaded enough for this to be an issue, maybe the middle ground would be this "Advanced" tab:

What I would really love to see is an "Advanced" tab (or subtab) in the Settings where we could put stuff to make Teeworlds a bit more customisable without bloating the usual tabs.

A quick suggestion:

image

@oy
Copy link
Member

oy commented Nov 16, 2018

That feels kinda misplaced there. Should probably be in the subcategory where it belonged too.

@Zatline
Copy link
Member

Zatline commented Nov 18, 2018

there was a strong intent to keep maximal button count at six per row with buttons being of same size everywehere it's kind of embedded in the design.
I wouldn't like this as it would make buttons start vary in size and consistency fade.

@Dune-jr
Copy link
Member Author

Dune-jr commented Nov 18, 2018

I would love any alternative suggestions.

@1stDecadeTW
Copy link

Add sub-pages within each tab with advanced options/features (or maybe not frecuently used, but useful features for players, server admins and developers).

screenshot_1

@oy
Copy link
Member

oy commented Nov 19, 2018

You could add a scrollbar to a setting subcategory or and advanced section.

@Dune-jr
Copy link
Member Author

Dune-jr commented Nov 19, 2018

I would like an advanced section, but I have no idea how it could be accessed.

@oy
Copy link
Member

oy commented Nov 19, 2018

Should be within the correspoding subcategory not in the top menu.

@Dune-jr
Copy link
Member Author

Dune-jr commented Nov 19, 2018

So chat/HUD customization stuff - if implemented - should be a subcategory of UI?

edit: whoops, that's not a category

@oy
Copy link
Member

oy commented Nov 19, 2018

There's no UI-category right now, should be in general, but yeah.

@Robyt3
Copy link
Contributor

Robyt3 commented Jan 22, 2020

I think we should add another tab "HUD" or "Interface" with

  • most of the settings under General/Game
  • theme settings, probably
  • Chat options #2293 as a table

This would free up the general page and allow some of the above mentioned options to have UI, if they are useful for the average player.

If there is not enough room for another tab, maybe the tabs could be rearranged to go from top to bottom on the left or right side.

@Dune-jr
Copy link
Member Author

Dune-jr commented Jan 27, 2020

Well, a lot of the aforementioned options ended up working out somehow, or are edge cases, or bloat (cf @oy and @LordSk's feedback). Only the statboard options and #2293 remain imo.

  • Putting the Settings tabs on the right, like they were in 0.6 Teeworlds, would not fit the new interface
  • Adding more tabs is not great because translations would start overflowing (so we'd have to reduce the font size?)

A lot of games have the whole settings page be a scroll region:

image
image

In the case of Teeworlds, the issue here is nested Clip regions, that don't work so well. The CScrollRegion class would otherwise be nestable.

Another option I would see is an "Advanced settings" button that let you go to a second page, e.g.

--- Section ----
[ ] Option          [ ] Option 
[ ] Option          [ ] Option 
[ ] Option          [ ] Option 

---- Section ----
[ ] Option 
[ ] Option 
[ ] Option 
[ ] Option 
[ ] Option 

--- Section ----
[ ] Option          [ ] Option 
[ ] Option          [ ] Option 
[ ] Option          [ ] Option 

            vvvv   Advanced options vvvvvv

and

            ^^^^^   Basic options ^^^^^^

--- Section ----
[ ] Option          [ ] Option 
[ ] Option          [ ] Option 

---- Section ----
[ ] Option 
[ ] Option 
[ ] Option 
[ ] Option 
[ ] Option 
[ ] Option 
[ ] Option 

@oy
Copy link
Member

oy commented Jan 27, 2020

Using scrollbars seems like a good idea 👍
Also about the tabs: "Player" and "Tee" could be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants