Skip to content
This repository has been archived by the owner on Oct 16, 2022. It is now read-only.

Unmount #10

Closed
Djaler opened this issue Jun 6, 2017 · 9 comments
Closed

Unmount #10

Djaler opened this issue Jun 6, 2017 · 9 comments

Comments

@Djaler
Copy link
Contributor

Djaler commented Jun 6, 2017

Looks like you forgot to unmount /mnt/timeshift/backup after app close in btrfs mode.

@teejee2008
Copy link
Owner

It's intentional. There's no harm in leaving it mounted for the next scheduled backup.

@teejee2008 teejee2008 self-assigned this Sep 10, 2017
@Djaler
Copy link
Contributor Author

Djaler commented Sep 10, 2017

It works wrong with btrfs. Nested snapshots created

@emanuc
Copy link

emanuc commented Feb 27, 2018

umount snapshot is an important feature, for example it saves you if you accidentally type a command that damages the system: "sudo rm -rf / *".
I made a video on this feature that had timeshift-btrfs, ie the ability to restore the system after typing the command that damages the whole system (sudo rm -rf / *): https://www.youtube.com/watch?v=VdmDJ3cBmZM&t=250s
With timeshift I tried, it also eliminates the snapshot, so it is no longer possible to recover the system.

@Stibila
Copy link

Stibila commented Jul 22, 2018

Can we reopen this as feature request? I too think that leaving mounted snapshots is bad idea.

@teejee2008 teejee2008 reopened this Jul 22, 2018
@Djaler
Copy link
Contributor Author

Djaler commented Jul 22, 2018

IMHO, this can be related to #141

@emanuc
Copy link

emanuc commented Apr 11, 2020

Could you put a flag if setting a snapshot in RO?
So another advantage is that you could use "btrfs send" to export it to another disk.
btrfs property set -ts /path/to/snapshot ro true

https://btrfs.wiki.kernel.org/index.php/Manpage/btrfs-property#btrfs-property.288.29_manual_page

@Golddouble
Copy link

I also would like to have this in rsync mode.
I guess, this woulöd also solve this unexpected behaviour:
#675

@erikjms
Copy link

erikjms commented Jun 13, 2021

I am also interested in a better way to manage timeshift volumes. I backup to a micro SD card in my laptop, and often I want to use the single micro SD port for something else. Using the command line to unmount the timeshift volume without knowing whether timeshift is currently writing to that volume seems unwise--although, in the grand scheme of things, perhaps not catastrophically so. But it might result in a corrupted backup, and depending on how many backups one keeps on hand, that could be quite annoying.

It would be nice either: to have a tool to unmount the volume after checking that timeshift is not currently writing/reading it; or for timeshift simply to mount/unmount the volume as needed. Myself, I'm not good enough a bash wrangler to know how best to safely unmount the volume with a custom shell script. Otherwise that is precisely what I would do.

@Moonbase59
Copy link

Moonbase59 commented Apr 29, 2022

There are already lots of issues about this behaviour: https://github.com/teejee2008/timeshift/issues?q=is%3Aissue+is%3Aopen+umount

I agree this should please be fixed. It’s great that Timeshift can find and automount external backup drives, but it should really umount its own mount point again after doing its work.

Otherwise, especially with modern Linuxes "automount when USB inserted" behaviour, this leads to lots of unexpected problems, especially with non-tech-savy users.

teejee2008 added a commit that referenced this issue May 28, 2022
… Timeshift before exit

Any devices that Timeshift needs to mount will be mounted under /run/timeshift/<pid> and unmounted on application exit
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

7 participants