-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
error TS2304: Cannot find name 'StringDecoder'.
with v6.6.1
#1008
Comments
Hi @anthonylau, can you provide some details on how did you compile your project or maybe provide a reproduce script? I have set up the tedious project with the versions that you provide, and the tedious project builds fine. Also, do you want to try your project with a newer version of Typescript since that 3.3.3333 is released about 9 months ago? |
Hey @MichaelSun90, I have the same issue as @anthonylau was having. I also fixed it with going for tedious v6.5.0. running my start scrip (
I use it in combination with What additional information do you need? |
additonal info: |
I've trouble understanding where this issue is coming from -- based on https://github.com/DefinitelyTyped/DefinitelyTyped/blob/6a3064cc7408b4e71d0d0feb6f92457d4c22e15c/types/readable-stream/index.d.ts#L132, there is no reference to Can you check the contents of the |
Yeah I checked, and the ReadableState interface looks as follows:
This is the tedious dependency that it has installed:
|
So it looks like readable-stream v 2.3.6 has been merged with This is probably a DefinitelyTyped problem
I think you're looking at the wrong readable-stream dependency. The problem lies in @Types/readable-dependency, which should have 2.3.5 installed |
An issue about this has already been raised DefinitelyTyped/DefinitelyTyped#37869 Here's the fix: @anthonylau @obermobber . Hopefully this also fixes your issue! |
Yeah, was just going to write that! |
When I compile my project,
Node: 10.16.0
Typescript: 3.3.3333
tedious: 6.6.1
It works if I change tedious version to 6.5.0.
Not sure if this is related to #1007
Would anyone advise?
The text was updated successfully, but these errors were encountered: