Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC - Remove debug dependency from production #840

Open
dhensby opened this issue Mar 25, 2019 · 3 comments
Open

RFC - Remove debug dependency from production #840

dhensby opened this issue Mar 25, 2019 · 3 comments

Comments

@dhensby
Copy link
Collaborator

dhensby commented Mar 25, 2019

We currently have debug as a prod dependency as calls to it are scattered through our code. This isn't great.

We should have a reporter function we call that the consumer can hook into, this could be debug or it could be any other kind of logger.

@willmorgan
Copy link
Collaborator

The beauty of using the debug library is that you can switch it on and off via EV/app setting, and as it's likely shared across various other dependencies in the Node ecosystem, you can tweak visibility of messages to the library.

So I'm in favour of the reporter function that's configurable but would like to see debug remain as a default should none be configured.

@aklietz
Copy link

aklietz commented Aug 3, 2020

Debug is useful for troubleshooting MSSQL connectivity problems in a production environment. (DEBUG=mssql:*,tedious:* node server.js) I also would like to see it kept as the configured default.

@dhensby
Copy link
Collaborator Author

dhensby commented Aug 3, 2020

The idea wouldn't be to remove calls to a logger, but more for that to be a logger that can be defined by the consumer rather than by this library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants