Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workspace dependencies #1147

Open
rm-dr opened this issue Feb 14, 2024 · 1 comment
Open

Workspace dependencies #1147

rm-dr opened this issue Feb 14, 2024 · 1 comment
Labels
chore Minor cleanup, version bumps, etc dependencies Issues with crates we depend upon

Comments

@rm-dr
Copy link
Contributor

rm-dr commented Feb 14, 2024

Is there a reason we're not using { workspace = true } in sub-crate Cargo.toml files?
It would be nice to specify crate paths and versions in exactly one place, instead of listing all versions of all dependencies independently in each crate.

@rm-dr rm-dr added the dependencies Issues with crates we depend upon label Feb 14, 2024
@pkgw
Copy link
Collaborator

pkgw commented Feb 14, 2024

It took me a little while to track down what you were referring to, so, for posterity:

https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html#inheriting-a-dependency-from-a-workspace

I think we're not using it simply because it's a relatively new feature. It is possible that intra-workspace dependencies might cause some wrinkles that I would need to deal with in my Cranko release automation tool, but ... also maybe not?

@rm-dr rm-dr added the chore Minor cleanup, version bumps, etc label Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Minor cleanup, version bumps, etc dependencies Issues with crates we depend upon
Projects
None yet
Development

No branches or pull requests

2 participants