Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shouldSplitCellsOnPageBeak is ignored #243

Closed
haemi opened this issue Oct 14, 2020 · 7 comments
Closed

shouldSplitCellsOnPageBeak is ignored #243

haemi opened this issue Oct 14, 2020 · 7 comments
Labels

Comments

@haemi
Copy link

haemi commented Oct 14, 2020

I try to create a table where cells are not split on a page break. I stumbled upon the property shouldSplitCellsOnPageBeak which is false per default, so I would expect it to work as I like. But it seems the property is ignored.

When searching for that word, I only find it once, it seems as if it's never used... Is there a way to prevent cells to be split on page break?

@philprime
Copy link
Member

Hi @haemi, which branch are you working on?

This is actually still a WIP in PR #223 so it's kind of weird the flag is already in a released version 🤔

@haemi
Copy link
Author

haemi commented Oct 14, 2020 via email

@philprime
Copy link
Member

Oh yes, I just checked out the master branch.
Looks like this was released in the most recent branch, as the flag already existed on develop but is not used yet.

Thanks a lot for reporting this!

@haemi
Copy link
Author

haemi commented Oct 14, 2020 via email

@philprime
Copy link
Member

You can take a look at branch feature/205-optional-table-cell-splicing if it already fits your needs, unfortunately due to time issues it might not be stable yet.

@haemi
Copy link
Author

haemi commented Oct 14, 2020

looks good, thanks a lot! The only problem left now is only that my cell is pretty wide, so an image can be too high to fit on one page - and I didn't find a way yet to make it smaller (when I make the UIImage itself smaller, the image in the table has the same size with less quality...)

@philprime
Copy link
Member

Alright, merged and release in 2.3.2

The image resizing issue was mentioned in #251 so let's move that discussion over there, so this issue does not get polluted.

If the splitting cell issue still remains in the new release, please reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants