Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The reason of lagging, lack of smoothness in search & home view #7

Open
Nephys222 opened this issue Aug 21, 2023 · 7 comments
Open

Comments

@Nephys222
Copy link

Of course it would not be identical to Spotify but with this beautifully written with latest Android libraries lacks smoothness home & search fragments. Is this the cause of Jetpack Compose or about acquiring data from Spotify API?

Help & answer would really appreciated!

@Nephys222
Copy link
Author

@t3chkid If you could help!

@technophilist
Copy link
Owner

Hey there. If you're talking about the demo video of the app, then the lag is because of the emulator and not the actual app. If you're referring to the app itself, then I'm not sure.
It might be because of the device that you tried to run it on, or, it might be because of some performance related mistake that I might've made.

@Nephys222
Copy link
Author

@t3chkid Thanks for your reply! I did test on Android 7.0 Nougat. The issues were on it. Are you planning to maintain the app and accept PRs or it is one-time project?

@technophilist
Copy link
Owner

Unfortunately it's a one time project of mine and I've stopped development of the project a while back. But I'm still curious on what might be causing the performance issue. Would you mind specifying the device on which you actually tested it on?

@Nephys222
Copy link
Author

@t3chkid Of course. It is at HTC One M9 Android 7.0. Also tested on Redmi 10C Android 12. It is more smoother on it. Here is video from HTC One M9.

At home there is some view anchoring issue
https://github.com/t3chkid/Musify/assets/59939839/7113f42c-de16-4b47-8a11-d46bbbbf6c17

Search view.
https://github.com/t3chkid/Musify/assets/59939839/3be68834-615f-4b43-b236-c00adee8f4c3

@technophilist
Copy link
Owner

Thanks for that detailed reply with very useful screen recordings. Yea, I think there's some issue with how the filter chips row react to scrolling in the Home Screen. I'll definitely try to fix that.

Regarding the lag, it's a HTC One M9, a phone released in 2015. Ofc it's gonna lag at times. So, I don't think performance is an issue.

@technophilist
Copy link
Owner

technophilist commented Jan 15, 2024

I know it's been a while, but the lag that you might be facing might be cause because of the fact that you might be running the debug version of the app. As you probably know, compose might have some performance issues in debug mode. Build the app in release mode and try again. I tried it out and I definitely found the app to be much more snappy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants