Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move away from deprecated master role #339

Open
twistedgrim opened this issue Jul 30, 2023 · 2 comments
Open

Move away from deprecated master role #339

twistedgrim opened this issue Jul 30, 2023 · 2 comments
Labels
good first issue Good for newcomers

Comments

@twistedgrim
Copy link

It would be nice to move to the newer control plane taints on nodes that are used as control plane nodes. As people use the playbook and charts and apps rely on the control plane taint more than a master taint it will start to cause issues. More info below.

Migrate from the old deprecated master taint to the new control-plane taint.
Kubernetes docs from 1.20 show this change.

  • The label applied to control-plane nodes "node-role.kubernetes.io/master" is now deprecated and will be removed in a future release after a GA deprecation period.

  • Introduce a new label "node-role.kubernetes.io/control-plane" that will be applied in parallel to "node-role.kubernetes.io/master" until the removal of the "node-role.kubernetes.io/master" label.

  • Make "kubeadm upgrade apply" add the "node-role.kubernetes.io/control-plane" label on existing nodes that only have the "node-role.kubernetes.io/master" label during upgrade.

  • Please adapt your tooling built on top of kubeadm to use the "node-role.kubernetes.io/control-plane" label.

  • The taint applied to control-plane nodes "node-role.kubernetes.io/master:NoSchedule" is now deprecated and will be removed in a future release after a GA deprecation period.

  • Apply toleration for a new, future taint "node-role.kubernetes.io/control-plane:NoSchedule" to the kubeadm CoreDNS / kube-dns managed manifests. Note that this taint is not yet applied to kubeadm control-plane nodes.

@egandro
Copy link
Contributor

egandro commented Nov 2, 2023

Same issue with hardcoded names "master" in the roles.

@bdsoha
Copy link
Contributor

bdsoha commented May 9, 2024

@twistedgrim
CC: @egandro
This seems to be fixed with the introduction of group_name_master.
IMO, this can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants