Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update playbooks to have boolean when needed true/false and not yes or no #204

Open
jmbertoncelli opened this issue Jan 17, 2023 · 3 comments
Open

update playbooks to have boolean when needed true/false and not yes or no #204

jmbertoncelli opened this issue Jan 17, 2023 · 3 comments
Labels
good first issue Good for newcomers

Comments

@jmbertoncelli
Copy link

update playbooks to have boolean when needed true/false and not yes or no.
@timothystewart6
Copy link
Contributor

timothystewart6 commented Jan 19, 2023 •
edited

Hey, thanks, It's definitely valid and ansible converts it to a boolean value. I am definitely a fan over booleans than strings though, yes always seemed weird.

@timothystewart6 timothystewart6 added the good first issue Good for newcomers label Jan 20, 2023
@timothystewart6 timothystewart6 mentioned this issue Feb 14, 2023
Merged
6 tasks
@timothystewart6
Copy link
Contributor

Just a note that if anyone takes this on, they will also need to update the linting rules too.

@irish1986
Copy link
Contributor

I will have a crack at this and will need some help with comment and criticism.

balazshasprai added a commit to balazshasprai/k3s-ansible that referenced this issue Oct 27, 2023
@balazshasprai
Update truthy values to true/false only, techno-tim#204
9b422ce
@balazshasprai balazshasprai mentioned this issue Oct 27, 2023
Merged
6 tasks
narigondelsiglo pushed a commit to narigondelsiglo/techno-tim-k3s-ansible that referenced this issue Nov 22, 2023
Squashed commit of the following:
180bf17 
commit 9b422ce
Author: Balázs Hasprai <balazs.hasprai@hbalazs.com>
Date:   Fri Oct 27 12:42:47 2023 +0200

    Update truthy values to true/false only, techno-tim#204
timothystewart6 added a commit that referenced this issue Jan 15, 2024
@balazshasprai @timothystewart6
Update truthy values to true/false only, #204 (#387)
cddbfc8 
Co-authored-by: Techno Tim <timothystewart6@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@timothystewart6 @jmbertoncelli @irish1986