Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Activate Workflow #13

Open
3 of 5 tasks
mike4git opened this issue Jan 7, 2023 · 2 comments
Open
3 of 5 tasks

Activate Workflow #13

mike4git opened this issue Jan 7, 2023 · 2 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@mike4git
Copy link
Collaborator

mike4git commented Jan 7, 2023 •
edited by jdreesen

We need a workflow running for each PR to guarantee:

  • Checkstyle fixed
  • No Phpstan errors
  • Tests all running green
  • Test Coverage of new code is at least 80%
  • Analyze layer rules with deptrac
@jdreesen jdreesen added enhancement New feature or request help wanted Extra attention is needed labels Feb 5, 2023
@mike4git
Copy link
Collaborator Author

@jdreesen
What would you think about this way: https://itnext.io/github-actions-code-coverage-without-third-parties-f1299747064d
???

@lukadschaak
Copy link
Contributor

I have that Link already in my bookmarks :) But the priority is very low. So when you have time, feel free.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jdreesen @lukadschaak @mike4git