Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-hydrostatic solver #370

Open
tomchor opened this issue Aug 19, 2022 · 5 comments
Open

Non-hydrostatic solver #370

tomchor opened this issue Aug 19, 2022 · 5 comments

Comments

@tomchor
Copy link
Contributor

tomchor commented Aug 19, 2022

Hi, everyone, I just stumbled into this project after watching this JuliaCon session and let me start by saying that I really enjoy its vision and scope!

I've been reading through the docs and it seems like you don't have the capability of running nonhydrostatic LES, do I understand that correctly?

If so, do you envision them to be implemented soon? From the intro I get the feeling that the nonhydrostatic solver will be ported soon from pyOM2, but I see no mention of LES closures. I ask this because I think that if LES are possible with this package, it'll open up many more research avenues given the extensibility of the model and ability to run on multiple GPUs.

Thanks!

@dionhaefner
Copy link
Collaborator

Hey, glad you like the project! It is correct that we have not ported PyOM2's non-hydrostatic solver, so we do not have support for these setups.

So far we didn't need a non-hydrostatic solver for our own work, and my time is limited at the moment, so I wouldn't expect this to happen anytime soon unless someone volunteers.

It's not a huge deal to port it, in principle you just need to assemble the correct matrix and find efficient settings for the solvers. All the boilerplate is already there for the pressure solver. But the devil might be in the details.

@dionhaefner dionhaefner changed the title LES capabilities Non-hydrostatic solver Aug 20, 2022
@tomchor
Copy link
Contributor Author

tomchor commented Aug 20, 2022

Thank you! Is the same true for LES closures? (e.g. Smagorinsky-Lilly)

@dionhaefner
Copy link
Collaborator

Yea we don't have those either. We are currently focused on integrating sea-ice and biogeochemistry plugins and LES hasn't really been on our radar :)

That said if anyone wants to contribute something (even something very simple) they have my full support.

@tomchor
Copy link
Contributor Author

tomchor commented Aug 22, 2022

Sounds good. Thanks! And good luck with the project :)

@tomchor tomchor closed this as completed Aug 22, 2022
@dionhaefner
Copy link
Collaborator

Let's keep this open so we don't forget about it 😉

@dionhaefner dionhaefner reopened this Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants