Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add an option to deal with couchdb conflicts #31

Open
tdebarochez opened this issue Jul 11, 2014 · 3 comments
Open

add an option to deal with couchdb conflicts #31

tdebarochez opened this issue Jul 11, 2014 · 3 comments
Labels

Comments

@tdebarochez
Copy link
Owner

In the case where two concurrent commits are made on the same session, a conflict might occurs. I see three ways to deals with it :

  • throw an exception (actual scenario, but it should be better handled)
  • ignore it
  • erase the actual stored session
@eddiesholl
Copy link

Any interest in this issue getting addressed? I can see how different users would want to either ignore or throw, based on how important their session data is. Consider a PR?

@tdebarochez
Copy link
Owner Author

I gladly accept every well tested PRs. :)

@eddiesholl
Copy link

eddiesholl commented Sep 30, 2016

I've added basic support for ignoring conflicts at https://github.com/eddiesholl/connect-couchdb/tree/conflicts, I'm getting a few other test breakages that I don't think are caused by my changes. If you have a moment do you mind trying it out?

Do you think support for passing in a conflict handling function is required here as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants