Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nanorange failed with error C2607 on MSVC #113

Open
QuellaZhang opened this issue Mar 23, 2021 · 3 comments
Open

Nanorange failed with error C2607 on MSVC #113

QuellaZhang opened this issue Mar 23, 2021 · 3 comments

Comments

@QuellaZhang
Copy link

Hi all,

NanoRange assert failed on upcoming version of MSVC: F:\gitP\tcbrindle\nanorange\test\test_concepts.cpp(183): error C2607: static assertion failed

The failing line is:

static_assert(rng::default_initializable);

which eventually reaches:

template
inline constexpr bool
is_default_initializable<T, std::void_t<decltype(::new T)>> = true;

'::new const int' is not valid as you cannot default initialize a 'const int'.

@tcbrindle
Copy link
Owner

Thanks for the notification, I think I reported this bug in MSVC so it's good to see it's been fixed (and also that this comment seemed to work!).

Could you tell me the value of _MSC_VER in the fixed version?

@CaseyCarter
Copy link
Contributor

I think I reported this bug in MSVC so it's good to see it's been fixed

Yes, you reported it on DevCom. I saw Jon Caves fixing a very similar bug and convinced him to get this one as well so our default_initializable implementations will work. 🎉

Could you tell me the value of _MSC_VER in the fixed version?

1929, which will be the _MSC_VER for both 16.10 and 16.11. This will probably be in 16.10p3.

@tcbrindle
Copy link
Owner

Thanks Casey!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants