Skip to content
This repository has been archived by the owner on Jun 3, 2020. It is now read-only.

Preserve manifest formatting: Attribute ordering and comments #45

Open
volosied opened this issue Mar 1, 2020 · 1 comment
Open

Preserve manifest formatting: Attribute ordering and comments #45

volosied opened this issue Mar 1, 2020 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@volosied
Copy link
Collaborator

volosied commented Mar 1, 2020

When I run the transfer tool on a feature manifest, the attributes are reorganized. Rules and Manifests are attached.

rules.zip

mf.zip

I don't believe this should affect the transformation's ability to run, but I think it should output everything in the same order for consistency. And it's easier to run diff on it, too.

I upgraded this to a bug. The manifest and feature updates should keep these files in their original format / order as much as possible. That means preserving attribute order. That also means preserving comments. White space generally cannot be preserved because of manifest format requirements.

@volosied volosied added the question Further information is requested label Mar 1, 2020
@tbitonti tbitonti changed the title Attribute Reorangization for Feature Manifests Attribute Reorganization for Feature Manifests Mar 16, 2020
@tbitonti
Copy link
Owner

This is a good idea. It would require taking over the manifest read step and changing the property storage to be order preserving, making it a medium-ish sized chunk of work.

@tbitonti tbitonti self-assigned this Mar 18, 2020
@tbitonti tbitonti added bug Something isn't working and removed question Further information is requested labels May 11, 2020
@tbitonti tbitonti changed the title Attribute Reorganization for Feature Manifests Preserve manifest formatting: Attribute ordering and comments May 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants