Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"No stream" mode does not work #249

Closed
3 tasks done
johnd0e opened this issue May 9, 2024 · 3 comments
Closed
3 tasks done

"No stream" mode does not work #249

johnd0e opened this issue May 9, 2024 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@johnd0e
Copy link

johnd0e commented May 9, 2024

What happened?

There is an command line option to "--stream" output.
But even when I do not specify it - the output is also streamed.

How can we reproduce this?

sgpt "tell me a story"

As there is no options, I expect the output appears all at once, but it is streamed instead.

sgpt version

2.13.0

Search

  • I did search for other open and closed issues before opening this

Project

  • I have verified that I am using the Go implementation of SGPT (this project) and that it is not another project

Code of Conduct

  • I agree to follow this project's Code of Conduct

Additional context

No response

@johnd0e johnd0e added the bug Something isn't working label May 9, 2024
@tbckr
Copy link
Owner

tbckr commented May 10, 2024

Hey, thank you for your bug report. Could you please share your configuration with me?
You can get your current config with the sgpt config show command.

@johnd0e
Copy link
Author

johnd0e commented May 10, 2024

maxtokens: 2048
model: gpt-4
stream: true
temperature: "0.7"
topp: "1"

And after reading https://sgpt.readthedocs.io/en/latest/configuration/, I now see the point:

These options override the default values for the corresponding command line options.

But that seems not good to me.
The common pattern is opposite: commandline options, being dynamic, should have higher priority over static config file.

@tbckr
Copy link
Owner

tbckr commented May 12, 2024

You are correct. What you describe is the intended behavior and the implemented state. If you do not want your response to be streamed, remove the entry from the config file or set it to false. The default for streaming is false.

If you specify the stream flag from the command line, the response is streamed. See the help output for more information.

The command line flags override the configuration values.

@tbckr tbckr closed this as completed May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants