Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HEALTHCHECK tags #95

Open
ShuP1 opened this issue Apr 16, 2020 · 1 comment
Open

Add HEALTHCHECK tags #95

ShuP1 opened this issue Apr 16, 2020 · 1 comment

Comments

@ShuP1
Copy link

ShuP1 commented Apr 16, 2020

I find (but it's a very personal opinion) docker's healthcheck very usefull.
Sadly they are not included in Nix repo.

Is there any simple way to add them to packages (like mariadb or redis) on a private repo ?

@jpetazzo
Copy link
Contributor

Hi @ShuP1,

The difficulty would be to decide what to use as a healthcheck. For instance, for redis, it could be redis-cli ping, for MariaDB something like mysql -e status, for CLI tool there shouldn't be a healthcheck. And what should we do for images holding multiple services?

AFAIK there isn't a generic way in Nix packges to specify a healthcheck (not that I could find in the Redis derivation, anyway), so I don't know how Nixery could figure out what to use. If someone who knows Nix and nixpkgs better than I do can chime in to confirm that it would be fantastic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants