Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git tags do not currently work as image tags #89

Open
tazjin opened this issue Feb 28, 2020 · 0 comments
Open

git tags do not currently work as image tags #89

tazjin opened this issue Feb 28, 2020 · 0 comments
Labels
bug Something isn't working

Comments

@tazjin
Copy link
Owner

tazjin commented Feb 28, 2020

As pointed out by @eonpatapon in #86:

And I found in the manual for builtins.fetchGit: By default, the ref value is prefixed with refs/heads/. As of Nix 2.3.0 Nix will not prefix refs/heads/ if ref starts with refs/.
So that means that nixery would need to know if the requested docker tag is a git tag or git branch of the current repo before calling fetchGit. Which is kind of tricky since you can have a tag and a branch that have the same name.

@tazjin tazjin added the bug Something isn't working label Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant