Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(core): remove window endpoints #6947

Merged
merged 5 commits into from May 12, 2023
Merged

refactor(core): remove window endpoints #6947

merged 5 commits into from May 12, 2023

Conversation

lucasfernog
Copy link
Member

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

tauri-apps/plugins-workspace#352

@lucasfernog lucasfernog requested a review from a team as a code owner May 11, 2023 17:34
@lucasfernog lucasfernog changed the base branch from next to refactor/event May 11, 2023 17:34
@lucasfernog lucasfernog changed the title refactor(core): move event JS API to plugins-workspace refactor(core): remove window endpoints May 11, 2023
wusyong
wusyong previously approved these changes May 12, 2023
View reviewed changes
Base automatically changed from refactor/event to next May 12, 2023 10:55
@lucasfernog lucasfernog merged commit 9a79dc0 into next May 12, 2023
37 checks passed
@lucasfernog lucasfernog deleted the refactor/window branch May 12, 2023 11:18
@luucasrb luucasrb mentioned this pull request Aug 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amrbashir amrbashir amrbashir approved these changes

@wusyong wusyong wusyong left review comments

Assignees
No one assigned
Labels
None yet
Projects
Roadmap
Status: 🔎 In audit
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lucasfernog @wusyong @amrbashir