[bug] Windows Updated Installer Does not Use Same GUID

[elibroftw]

Describe the bug

After updating an app, either manually or by using the Tauri Updater, the icon for the app on the Windows taskbar shows up as blank. The icon will always display correctly for the Start Menu shortcut but takes a couple of days to show correctly in the install location (irrelevant as this is based on my memory not hard proof). FYI, the icon in the taskbar was pinned from the start menu and not the app install location.

After a couple days, the icon in the install location shows properly (irrelevant):

But the icon of the app pinned to the taskbar remains blank:

If I downgrade my app, the icon shows up fine in the taskbar:

After unpinning the app, and pinning it from the app source, the issue is not present

I did some digging; I looked at the icon path for the Start Menu shortcut and the GUID changed after the update!

Reproduction

No response

Expected behavior

Shortcut icon path should not change between installs which necessitates that the GUID should not change between installs which necessitates that the GUID should not be changed for each installer or version of the app built.

Platform and versions

Environment
› OS: Windows 10.0.19044 X64
› Webview2: 107.0.1418.42
› MSVC:
- Visual Studio Community 2022
› Node.js: 18.12.1
› npm: 8.19.2
› pnpm: Not installed!
› yarn: 1.22.11
› rustup: 1.24.3
› rustc: 1.61.0
› cargo: 1.61.0
› Rust toolchain: stable-x86_64-pc-windows-msvc

Packages
› @tauri-apps/cli [NPM]: 1.2.0
› @tauri-apps/api [NPM]: 1.2.0
› tauri [RUST]: 1.2.0,
› tauri-build [RUST]: 1.2.0,
› tao [RUST]: 0.15.3,
› wry [RUST]: 0.22.0,

App
› framework: React
› bundler: Rollup

App directory structure
├─ .git
├─ .github
├─ .idea
├─ assets
├─ build
├─ node_modules
├─ public
├─ src
├─ src-tauri
└─ utils

Stack trace

No response

Additional context

This is a double issue. The top level issue is that the shortcut icon pinned to the taskbar is different after installing an update. The root problem is the GUID is changing for each installer built. This is not mentioned under https://tauri.app/v1/guides/building/cross-platform nor is it mentioned at the top of https://tauri.app/v1/guides/building/windows nor does it show up under search

Under https://stackoverflow.com/questions/1405100/change-my-component-guid-in-wix/1422121,

Your updated MSI delivers a new version of MyFile.exe. The location is the same as before, this means the component GUID should not change. It is the same file (identity), just in a different version.

https://stackoverflow.com/a/5834288/7732434

More info if you need it.

[lucasfernog]

I'm not sure if a consistent GUID has other implications, but it did not fix the issue to me. A good resource on this was this issue comment. I'll open a PR changing the RemoveExistingProducts scheduling, which did fix the problem. I also tested to see if resources are kept across updates, which is the case (that can be problematic if we schedule it too late).