Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] msi installer language setting, Japanese is ja-JP but jp-JP #5342

Closed
santmove opened this issue Oct 4, 2022 · 0 comments
Closed

[bug] msi installer language setting, Japanese is ja-JP but jp-JP #5342

santmove opened this issue Oct 4, 2022 · 0 comments
Labels
status: needs triage This issue needs to triage, applied to new issues type: bug

Comments

@santmove
Copy link

santmove commented Oct 4, 2022

Describe the bug

Excuse me for my poor English.

If you put "jp-JP" in the language of tauri.conf.json and build, the msi will not be in Japanese,
and if you put "ja-JP", you will get a panicked error and you can't build.

Reproduction

  1. Put "jp-JP" in the language of tauri.conf.json
    "wix": { "language":{ "jp-JP":{ "localePath":"./path/to/jp-JP.wxl" } },

  2. Put 'jp-JP.wxl' in ./path/to/jp-JP.wxl

<?xml version="1.0" encoding="utf-8"?> <WixLocalization Codepage="932" Culture="jp-JP" xmlns="http://schemas.microsoft.com/wix/2006/localization"> <String Id="TauriLanguage">1041</String> <String Id="TauriCodepage">932</String> ...

  1. yarn tauri build
    the msi will not be in Japanese.

  2. Put "ja-JP" in the language of tauri.conf.json
    "wix": { "language":{ "ja-JP":{ "localePath":"./path/to/ja-JP.wxl" } },

  3. Put 'ja-JP.wxl' in ./path/to/ja-JP.wxl

<?xml version="1.0" encoding="utf-8"?> <WixLocalization Codepage="932" Culture="ja-JP" xmlns="http://schemas.microsoft.com/wix/2006/localization"> <String Id="TauriLanguage">1041</String> <String Id="TauriCodepage">932</String> ...

  1. yarn tauri build
    can't build
main.wxs
thread '<unnamed>' panicked at 'Language ja-JP not found. It must be one of ro-R
O, en-US, es-ES, lt-LT, el-GR, sv-SE, tr-TR, et-EE, nl-NL, nb-NO, bg-BG, zh-CN,
jp-JP, pt-BR, vi-VN, pl-PL, da-DK, pt-PT, lv-LV, fr-FR, zh-TW, he-IL, de-DE, ca-
ES, ru-RU, sk-SK, ko-KR, cs-CZ, eu-ES, sr-Latn-CS, uk-UA, th-TH, hu-HU, it-IT, s
l-SI, ar-SA, hr-HR, fi-FI', D:\a\tauri\tauri\tooling\bundler\src\bundle\windows\
msi\wix.rs:780:7
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
Done in 3.72s.

Expected behavior

Looking at the specifications below, I think ja-JP is probably correct.
https://learn.microsoft.com/en-us/openspecs/office_standards/ms-oe376/6c085406-a698-4e12-9d4d-c3b0ee3dbc4a
On this page, Japanese is written as "ja-JP"

Platform and versions

Environment
› OS: Windows 10.0.19044 X64
› Webview2: 105.0.1343.53
› MSVC:
- Visual Studio Community 2019
- Visual Studio Build Tools 2022
› Node.js: 16.17.0
› npm: 8.15.0
› pnpm: Not installed!
› yarn: 1.22.5
› rustup: 1.25.1
› rustc: 1.63.0
› cargo: 1.63.0
› Rust toolchain: stable-x86_64-pc-windows-msvc

Packages
› @tauri-apps/cli [NPM]: 1.1.1
› @tauri-apps/api [NPM]: Not installed!
› tauri [RUST]: 1.1.1,
› tauri-build [RUST]: 1.1.1,
› tao [RUST]: 0.14.0,
› wry [RUST]: 0.21.1,

App
› build-type: bundle
› CSP: unset
› distDir: ../src
› devPath: ../src

App directory structure
├─ .vscode
├─ node_modules
├─ src
└─ src-tauri
npm notice
npm notice New minor version of npm available! 8.15.0 -> 8.19.2
npm notice Changelog: https://github.com/npm/cli/releases/tag/v8.19.2
npm notice Run npm install -g npm@8.19.2 to update!
npm notice

Stack trace

No response

Additional context

No response

@santmove santmove added status: needs triage This issue needs to triage, applied to new issues type: bug labels Oct 4, 2022
Kotaro7750 added a commit to Kotaro7750/TyperConcierge2 that referenced this issue Oct 22, 2022
resourcesとして加えた組み込み辞書ファイルのファイル名がASCIIでなかったのが問題であった

wixという仕組みでインストーラを作っているが制約でutf8のファイル名は使えない可能性がある

wixの設定を日本語にすればシフトjisを許容するようになるらしいが,日本語にする部分にバグがあったようなのでしばらくはASCIIのファイル名にする
cf. tauri-apps/tauri#1976
cf. tauri-apps/tauri#5342
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: needs triage This issue needs to triage, applied to new issues type: bug
Projects
None yet
Development

No branches or pull requests

1 participant