Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): wait for tray cleanup before exiting app, closes #5244 #5245

Merged
merged 3 commits into from Oct 4, 2022
Merged

fix(core): wait for tray cleanup before exiting app, closes #5244 #5245

merged 3 commits into from Oct 4, 2022

Conversation

amrbashir
Copy link
Member

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@amrbashir amrbashir requested a review from a team as a code owner September 20, 2022 13:43
amrbashir
amrbashir commented Sep 20, 2022
View reviewed changes
.changes/tray-cleanup.md Outdated Show resolved Hide resolved
@amrbashir amrbashir mentioned this pull request Sep 21, 2022
Closed
@lucasfernog lucasfernog merged commit f756cd5 into dev Oct 4, 2022
@lucasfernog lucasfernog deleted the fix-tray-cleanup branch October 4, 2022 20:02
@FabianLars FabianLars mentioned this pull request Nov 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucasfernog lucasfernog lucasfernog approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@amrbashir @lucasfernog