New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bug] Tauri crashes when using create_window with float number as label #3544
Comments
you can't have |
@amrbashir it's not that I need to have a The API specifies a label needs to be a string. I can imagine people namespacing their labels with |
cc @lucasfernog |
create_window already does return a Result which should give an error like this: " Window label must include only alphanumeric characters,
Edit2: Like amr said, check the audit report for the reasoning behind this. |
Glad to see this resolved. 🎉 |
Describe the bug
When I call AppHandle.create_window() or Window.create_window() with a floating number parsed into a
String
as the label the app crashes.Reproduction
Expected behavior
Either accept strings like
"1.0"
as valid label identifiers or if that's impossible return aResult
with an error that specifies that we provided an unsupported label.Platform and versions
Operating System - Mac OS, version 12.2.1 X64 Node.js environment Node.js - 16.13.2 @tauri-apps/cli - 1.0.0-rc.4 (outdated, latest: 1.0.0-rc.5) @tauri-apps/api - 1.0.0-rc.1 Global packages npm - 8.1.2 pnpm - 6.26.1 yarn - 1.22.0 Rust environment rustup - 1.24.3 rustc - 1.58.1 cargo - 1.58.0 toolchain - stable-x86_64-apple-darwin App directory structure /node_modules /static /scripts /src-tauri /.svelte-kit /build /.git /src App tauri - 1.0.0-rc.3 tauri-build - 1.0.0-beta.4 tao - 0.6.2 wry - 0.13.2 build-type - bundle CSP - unset distDir - ../build devPath - http://localhost:7024/ framework - Svelte
Stack trace
No response
Additional context
#[tauri::command]
. I don't think that's relevant, but mentioning just in case.String::new("5555")
works as expected.The text was updated successfully, but these errors were encountered: