Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Update request support include CPU info #3359

Closed
aiyanbo opened this issue Feb 8, 2022 · 8 comments
Closed

[feat] Update request support include CPU info #3359

aiyanbo opened this issue Feb 8, 2022 · 8 comments
Assignees

Comments

@aiyanbo
Copy link

aiyanbo commented Feb 8, 2022

Describe the problem

My app is built on the arm and x86 architectures of macOS, and I would like the application updates to return different download links based on CPU information.

Describe the solution you'd like

The CPU information can be passed through the request path or the headers.

It might be supported in https://github.com/tauri-apps/tauri/blob/next/core/tauri/src/updater/core.rs#L287

Alternatives considered

No response

Additional context

No response

@lucasfernog
Copy link
Member

We could change the target option to allow a target triple, idk if that needs any change.

@lucasfernog lucasfernog self-assigned this Mar 18, 2022
@lucasfernog
Copy link
Member

I'll be implementing this today.

@aiyanbo
Copy link
Author

aiyanbo commented Mar 20, 2022

@lucasfernog
Copy link
Member

@aiyanbo Why do you need the download url to be an array?

@aiyanbo
Copy link
Author

aiyanbo commented Mar 20, 2022

@lucasfernog

My app is distributed in different parts of the world and I want to use an effective CDN failback to resolve a single network failure.

@lucasfernog
Copy link
Member

That is already handled, the tauri.conf.json updater config is an array of urls

@lucasfernog
Copy link
Member

lucasfernog commented Mar 20, 2022

Though I can see a case where you might want to return a list of URLs on the updater JSON file format if that's what you're using. Can you file a separate feature request?

@aiyanbo
Copy link
Author

aiyanbo commented Mar 21, 2022

@lucasfernog OK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants