Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept a trait in the return of a #[command] #1672

Closed
chippers opened this issue May 1, 2021 · 0 comments
Closed

Accept a trait in the return of a #[command] #1672

chippers opened this issue May 1, 2021 · 0 comments

Comments

@chippers
Copy link
Member

chippers commented May 1, 2021

Is your feature request related to a problem? Please describe.
Accept a trait in the return of a #[command] function. Default implementations will include () and Result.

Describe the solution you'd like
We should implement this at the same time as #1665 and #1622 to change all aspects of #[command] codegen in a single release. It's likely I will implement this functionality this weekend.

Describe alternatives you've considered
/* ... */

Additional context
All 3 PRs will have the end result of a small change of with_window not doing anything as all things needed for knowing how to handle window will be moved to a trait. It's not a breaking change, but we will not be reading it and it should be removed from all examples and documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant