From 66b6136e06053e839b936ab17051d61748fa4f4e Mon Sep 17 00:00:00 2001 From: Dominik Schenk Date: Thu, 13 May 2021 00:33:17 +0200 Subject: [PATCH] Disable version check with semver for now (#1810) --- .changes/cli.js-package-check.md | 5 +++++ .../src/api/dependency-manager/managers/yarn-manager.ts | 6 +++--- tooling/cli.js/src/api/dependency-manager/util.ts | 6 ++++-- 3 files changed, 12 insertions(+), 5 deletions(-) create mode 100644 .changes/cli.js-package-check.md diff --git a/.changes/cli.js-package-check.md b/.changes/cli.js-package-check.md new file mode 100644 index 00000000000..4f4d496590a --- /dev/null +++ b/.changes/cli.js-package-check.md @@ -0,0 +1,5 @@ +--- +"cli.js": patch +--- + +Packages are checked with `!=` instead of `semver` for beta releases. diff --git a/tooling/cli.js/src/api/dependency-manager/managers/yarn-manager.ts b/tooling/cli.js/src/api/dependency-manager/managers/yarn-manager.ts index e427fccb179..8ef91280532 100644 --- a/tooling/cli.js/src/api/dependency-manager/managers/yarn-manager.ts +++ b/tooling/cli.js/src/api/dependency-manager/managers/yarn-manager.ts @@ -38,11 +38,11 @@ export class YarnManager implements IManager { getLatestVersion(packageName: string): string { const child = crossSpawnSync( 'yarn', - ['info', packageName, 'versions', '--json'], + ['info', packageName, 'version', '--json'], { cwd: appDir } ) const output = String(child.output[1]) - const packageJson = JSON.parse(output) as { data: string[] } - return packageJson.data[packageJson.data.length - 1] + const packageJson = JSON.parse(output) as { data: string } + return packageJson.data } } diff --git a/tooling/cli.js/src/api/dependency-manager/util.ts b/tooling/cli.js/src/api/dependency-manager/util.ts index 5500f07e1f1..94ad5709253 100644 --- a/tooling/cli.js/src/api/dependency-manager/util.ts +++ b/tooling/cli.js/src/api/dependency-manager/util.ts @@ -5,7 +5,7 @@ import { sync as crossSpawnSync } from 'cross-spawn' import { resolve as appResolve } from '../../helpers/app-paths' import { existsSync } from 'fs' -import semver from 'semver' +// import semver from 'semver' import { IManager, NpmManager, YarnManager, PnpmManager } from './managers' const getManager = (): IManager => { @@ -60,7 +60,9 @@ function padVersion(version: string): string { } function semverLt(first: string, second: string): boolean { - return semver.lt(padVersion(first), padVersion(second)) + return first !== second + // TODO: When version 1.0.0 is released this code should work again + // return semver.lt(padVersion(first), padVersion(second)) } export {