Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle context done when ci/cd job has a delay #151

Closed
samyfodil opened this issue May 9, 2024 · 2 comments · Fixed by #158
Closed

Handle context done when ci/cd job has a delay #151

samyfodil opened this issue May 9, 2024 · 2 comments · Fixed by #158
Labels
good first issue No deep understanding of tau needed

Comments

@samyfodil
Copy link
Contributor

In https://github.com/taubyte/tau/blob/main/protocols/monkey/jobs/run.go#L20, the go routine will wait but will not break if the context ends. It's already channels, all that needs to be done is wrap this up with a select and add a case for ctx.Done().
@samyfodil samyfodil added the good first issue No deep understanding of tau needed label May 9, 2024
@mortum5
Copy link
Contributor

mortum5 commented May 22, 2024

What error should be returned in case of ctx.Done()?

@samyfodil
Copy link
Contributor Author

Yes I would return an error.

@mortum5 mortum5 mentioned this issue May 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue No deep understanding of tau needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add select wrapper mortum5/tau
2 participants
@mortum5 @samyfodil