Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests being skipped because TAU_TEST_GIT_TOKEN -> TEST_GIT_TOKEN #146

Open
samyfodil opened this issue May 4, 2024 · 0 comments
Open

Tests being skipped because TAU_TEST_GIT_TOKEN -> TEST_GIT_TOKEN #146

samyfodil opened this issue May 4, 2024 · 0 comments
Labels
good first issue No deep understanding of tau needed urgent Urgent task

Comments

@samyfodil
Copy link
Contributor

samyfodil commented May 4, 2024

During a refactor environment variable TAU_TEST_GIT_TOKEN was changed to TEST_GIT_TOKEN

Some tests were disabled because of that. A solution is to add backward compatibility here https://github.com/taubyte/tau/blob/main/libdream/helpers/variables.go#L53
meaning: I can use TAU_TEST_GIT_TOKEN or TEST_GIT_TOKEN

Once that done, re-activate all tests affected by the issue like: https://github.com/taubyte/tau/blob/main/clients/p2p/auth/client_test.go

When testing you need to use a valid github token like this:

TEST_GIT_TOKEN=<valid-github-token-here> go test ./... -p 1

Some tests will run containers, so you'll need to have docker installed
Also, I recommend running with -p 1 as some tests are resource heavy

@samyfodil samyfodil added urgent Urgent task good first issue No deep understanding of tau needed labels May 4, 2024
@samyfodil samyfodil changed the title tests being passed because TAU_TEST_GIT_TOKEN -> TEST_GIT_TOKEN Tests being passed because TAU_TEST_GIT_TOKEN -> TEST_GIT_TOKEN May 4, 2024
@samyfodil samyfodil changed the title Tests being passed because TAU_TEST_GIT_TOKEN -> TEST_GIT_TOKEN Tests being skipped because TAU_TEST_GIT_TOKEN -> TEST_GIT_TOKEN May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue No deep understanding of tau needed urgent Urgent task
Projects
None yet
Development

No branches or pull requests

1 participant