Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List Setup box cannot be closed #428

Open
SupperDog opened this issue Jul 9, 2020 · 16 comments
Open

List Setup box cannot be closed #428

SupperDog opened this issue Jul 9, 2020 · 16 comments

Comments

@SupperDog
Copy link

Expected behavior:
When clicking the Cancel or X button on List Setup box, it should disappear without saving any changes.

Actual behavior:
The List Setup box does not disappear when clicking on the Cancel or X button.

Reproduce steps:
Login to admin dashboard, find a list (orders, menu items or whatever), click Setup button on header, the List Setup box appears. Click Cancel or X button on that box.

Version:
3.0.4.beta.22

Additional Information:
N/A

@sampoyigi
Copy link
Member

Works fine for me, do you have errors in your browser console log?

@SupperDog
Copy link
Author

There isn't any error in the console log. Quite strange. Have installed 2 copies both are the same. Also tried different browser.

@danielang
Copy link

Same behavior for me.

@sampoyigi
Copy link
Member

Does it work on a different browser?

@SupperDog
Copy link
Author

Does it work on a different browser?

No I've tried Google Chrome, Microsoft Edge, Firefox and Safari, none of them works.

@sampoyigi
Copy link
Member

Works for me on firefox and chrome

@SupperDog
Copy link
Author

Perhaps some files missed from the latest release?

@sampoyigi
Copy link
Member

Probably, but you should see an error in your console.log if its a case of missing files

@MyMediaGurus
Copy link

Sam - Open the setup box, untick one of the options, then try cancel or close the box - it won't work. You have to re-tick the option and press apply to close the window. There is nothing showing in Console, which I find very strange? Almost as though there is no action attached to the buttons when a change has been made. To be fair, the end result that you are forced to do in order to close the window, is the same as pressing cancel or x but I understand how some users may find it frustrating.

@sampoyigi
Copy link
Member

Thank you for the input.

Truly strange 🤯. I've tried both admin orders and reservations page, open the setup modal, tick one of the options and I'm still able to close the modal. Tried on both firefox and google chrome. And yeah, there's no event attached to the checkboxes or action attached to the buttons so it's a bit tricky to debug, can't even guess what it could be lol.

Good thing there's a workaround until we find a solution.

@aaronfisher83
Copy link

The alternative, to retick the item and apply, gives the same result...so for now, you probably have more important things to be on with :)

@SupperDog
Copy link
Author

I now just refresh the whole page to close it lol

@sampoyigi
Copy link
Member

Yea re-ticking the item makes no difference on my end, I guess we can manage with the workarounds until there's a fix 🤷‍♂️was hoping to have this fixed in the next update.

@ryanmitchell
Copy link
Member

I get this from time to time but it's definitely a bootstrap modal bug instead of a TI one - the close buttons aren't selectable at all even with a right click and inspect. We may just need to upgrade bootstrap modal?

@sampoyigi
Copy link
Member

Coolio, I'll do the bootstrap update. I have some UI improvements planned for the first RC.

@sampoyigi
Copy link
Member

This issue will be closed and archived in 3 days, as there has been no activity in the last 60 days. If this issue is still relevant or you would like to see it actioned, please respond and we will re-open this issue. If this issue is critical to your business, consider the Dedicated Support Service where a Service Level Agreement is offered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants