Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silent failure when there is a cycle #291

Open
TheLortex opened this issue Apr 20, 2022 · 1 comment
Open

Silent failure when there is a cycle #291

TheLortex opened this issue Apr 20, 2022 · 1 comment
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@TheLortex
Copy link
Contributor

So I've accidentally generated something similar to this opam file:
opam-monorepo.opam

opam-version: "2.0"
depends: [
    "opam-monorepo"
]
dev-repo: "opam-monorepo"
url {
  src: "https://github.com/ocaml/opam-monorepo.git"
}

where the main problem is that the package depend on itself.

Surprisingly, the solver doesn't complain and write a lockfile with 0 entries.

If the opam file has another name (no cycle), the solver works as expected and writes a lockfile with 36 entries.

@NathanReb NathanReb added the bug Something isn't working label Apr 21, 2022
@NathanReb
Copy link
Contributor

Good cacth! I have a slight idea how this might happen and it shouldn't be too hard to fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants