Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow adding the overlays when overlay is not added #273

Open
Leonidas-from-XIV opened this issue Mar 28, 2022 · 5 comments
Open

Allow adding the overlays when overlay is not added #273

Leonidas-from-XIV opened this issue Mar 28, 2022 · 5 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Leonidas-from-XIV
Copy link
Member

Currently we only display a warning to let the user know that the overlays are not included and it might lead to packages not installable because of missing dune ports. @samoht suggested that we make opam-monorepo add the overlay opam repo. It sounds like a reasonable idea (provided we ask the user for permission first), the opam libraries might allow doing this directly.

@NathanReb
Copy link
Contributor

I think it would be best not to temper with the user opam configuration. This is the reason why we didn't do this in the first place.

Using the repo list based solver instead for this would likely be better!

@Leonidas-from-XIV
Copy link
Member Author

I think if we make it opt-in it could be fine, but you're right - using repos explicitly instead of dealing with the opam configuration is better in many ways.

@NathanReb
Copy link
Contributor

One of the reason I'm suggesting this is because I think it requires about the same amount of work.

Setting the repo in the config via the opam libraries is likely a bit involved and requires write access to the opam state so opens up for serious issues.

If we realize it's a lot of work to do this using the new solver, I'm happy to have a temporary workaround using the opam switch config!

@TheLortex
Copy link
Contributor

Adding the overlay repository in a stateless fashion (without modifying the opam switch) would be very useful for mirage! Currently what we do is that the Makefile lock operation temporarily add dune-duniverse opam overlay to the switch's repositories. So I believe what's missing to use the repo list based solved is to support URL remotes.

@tmattio
Copy link
Collaborator

tmattio commented Jan 10, 2023

Related to #315, we can implement this easily in the explicit_repos_solver.

@TheLortex note that if Mirage was using the explicit_repos_solver, you wouldn't have to remove the opam-overlays after locking, you could specify the list of repo in the command line for instance.

@tmattio tmattio added enhancement New feature or request good first issue Good for newcomers labels Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants