Report work on objectives instead of workitems #218
Conversation
|
I think it might be ok to "upgrade" existing weeklies - ie the parser could accept WIs but the printer will print the corresponding objective. Ie it's ok to update the data (with some automatic translation) as well as the tool. |
gpetiot
force-pushed
the
report-on-objectives
branch
from
5549511
to
d944332
Compare
|
@samoht that might create issues with long-standing Work Items that get moved from objective to objective, e.g. Comp65. |
gpetiot
force-pushed
the
report-on-objectives
branch
2 times, most recently
from
3fd9066
to
7adf959
Compare
This sounds like an issue that would be very specific to Comp65, I know the scale of the project makes it hard to compare to other projects where the maintenance objective is the same year on year (like it's the case for ocamlformat and odoc). But still, for this to work we need to have 1 objective associated to N workitems, not the opposite. @rikusilvola is it feasible to make sure the compiler workitems and objectives comply with this rule? A soft upgrade like what samoht proposed sounds like the best idea to me. |
gpetiot
changed the title
|
Once this is merged we should probably release okra.1.0.0 |
No WI should be on two objectives anyway, just that they tend to move from objective to objective. I guess it's fine since it won't affect older weeklies. By 2025, we ought to all be reporting on objectives instead, and the Comp65 and other rolling WIs will be closed. |
gpetiot
force-pushed
the
report-on-objectives
branch
from
fc48d32
to
70fe483
Compare
gpetiot
force-pushed
the
report-on-objectives
branch
3 times, most recently
from
dd4311a
to
75c381f
Compare
gpetiot
force-pushed
the
report-on-objectives
branch
from
da5f086
to
4845d76
Compare
|
@rikusilvola @jmid the PR is ready for review and experimentation if you have time to try out this branch |
|
I've added tests for |
gpetiot
force-pushed
the
report-on-objectives
branch
from
e5010dc
to
2bfec2c
Compare
CHANGES: ### Changed - Lint: activity is now checked against objectives instead of workitems (tarides/okra#218, @gpetiot) - Cat/Aggregate: generated reports use objectives instead of workitems (tarides/okra#218, @gpetiot) - Use standardized categories for reporting non-engineering work time: Community, Hack, Learning, Leave, Management, Meet and Onboard (tarides/okra#230, @gpetiot) - Lint: check the quarter of workitems instead of their status (tarides/okra#228, @gpetiot) - Normalize error messages (tarides/okra#237, tarides/okra#239, @gpetiot) ### Added - Allow engineers to specify the number of working days (tarides/okra#232, @patricoferris) - Check that [--engineer] and [--team] are not both true (tarides/okra#233, @gpetiot) - Gen: add example entries for standardized categories (tarides/okra#236, @gpetiot)
CHANGES: ### Changed - Lint: activity is now checked against objectives instead of workitems (tarides/okra#218, @gpetiot) - Cat/Aggregate: generated reports use objectives instead of workitems (tarides/okra#218, @gpetiot) - Use standardized categories for reporting non-engineering work time: Community, Hack, Learning, Leave, Management, Meet and Onboard (tarides/okra#230, @gpetiot) - Lint: check the quarter of workitems instead of their status (tarides/okra#228, @gpetiot) - Normalize error messages (tarides/okra#237, tarides/okra#239, @gpetiot) ### Added - Allow engineers to specify the number of working days (tarides/okra#232, @patricoferris) - Check that [--engineer] and [--team] are not both true (tarides/okra#233, @gpetiot) - Gen: add example entries for standardized categories (tarides/okra#236, @gpetiot)
fix #167
also fixes #159
I've been trying a few things, the issue in making the linter more strict right now, is that older reports won't pass the linting unless we maintain a double-check (depending on the submitted date for example, e.g. like versioning the checks), which is the same problem as linting files that contain closed workitems, these files should pass the linting, but we should print a warning (see #170).
So I've opted for printing warnings when reporting on a workitem instead of an objective, and telling the user which objective to use if there is one.
The examples are in
test/cram/lint/db.tWhat do you think?