Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the bistro command #241

Open
gpetiot opened this issue Jun 24, 2020 · 3 comments · May be fixed by #392
Open

Remove the bistro command #241

gpetiot opened this issue Jun 24, 2020 · 3 comments · May be fixed by #392
Milestone

Comments

@gpetiot
Copy link
Member

gpetiot commented Jun 24, 2020

Calling dune-release without a sub-command is the same as calling dune-release bistro. Is there really a benefit to having this command? (not sure this is even properly documented)

@NathanReb
Copy link
Contributor

Maybe a better suited name would do the trick, something like dune-release auto or dune-release all.

Adding documentation and stating that it's the default command seems good enough but I think it's already the case for bistro

We can't remove it without doing a major release but if we wish to improve the doc and eventually add an alias we can do that already! We could then deprecate it and finally drop it when releasing 2.0!

@gpetiot gpetiot removed the question label Aug 18, 2020
@Leonidas-from-XIV
Copy link
Member

@NathanReb Should we move this for the 2.0.0 milestone? I fear that given we already started, it is a bit late to remove but we could at least deprecate it.

@NathanReb
Copy link
Contributor

I think it's fine to remove it in 2.0 without warning. Not best practice but I doubt anybody has a script that runs dune-release bistro so it's unlikely to break anything serious, and I doubt anyone would bother typing dune-release bistro when it's the same as dune-release.

@Leonidas-from-XIV Leonidas-from-XIV added this to the 2.0.0 milestone Sep 27, 2021
Leonidas-from-XIV added a commit to Leonidas-from-XIV/dune-release that referenced this issue Sep 27, 2021
@Leonidas-from-XIV Leonidas-from-XIV linked a pull request Sep 27, 2021 that will close this issue
Leonidas-from-XIV added a commit to Leonidas-from-XIV/dune-release that referenced this issue Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants