Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax Arc wrapping requirement #65

Open
AaronFeickert opened this issue Feb 23, 2024 · 0 comments
Open

Relax Arc wrapping requirement #65

AaronFeickert opened this issue Feb 23, 2024 · 0 comments

Comments

@AaronFeickert
Copy link
Collaborator

Both Statement and Witness require that certain fields be wrapped in Arc, under the assumption that the caller is likely to reuse data like parameters and input sets that are expensive to clone.

This requirement has a bad code smell; it could be that the caller would be fine using a more efficient Rc instead, or that it does not intend to reuse these values and therefore has no need for such a wrapping.

It may be preferable to refactor so as to avoid this requirement and provide the caller more flexibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant