Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cucumber] unignore leader failure tests and make them work #664

Open
sdbondi opened this issue Aug 18, 2023 · 1 comment
Open

[cucumber] unignore leader failure tests and make them work #664

sdbondi opened this issue Aug 18, 2023 · 1 comment
Assignees

Comments

@sdbondi
Copy link
Member

sdbondi commented Aug 18, 2023

No description provided.

@Cifko
Copy link
Contributor

Cifko commented Dec 5, 2023

Just a note why this isn't in progress.
The test works like this. We have committee of size n, then there is 1/n probability the one failed node will be hit in one block. So when we have transaction which is 3 blocks. There is a 1-(1-1/n)^3 probability we will actually trigger leader failure. That's quite high. But then we need a 3-chain to actually commit the transaction, which requires that we don't hit the failed leader in 3 consecutive blocks. Which is (1-1/n)^3. That's small.
In case of 4 nodes, there is ~58% chance that we trigger leader failure and ~42% chance that we form a 3 chain. That's flaky.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Selected for development
Development

No branches or pull requests

2 participants