Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mac] "Meta" / Cmd key not working for keyboard shortcuts #123

Open
noahkiss opened this issue Nov 25, 2023 · 1 comment
Open

[Mac] "Meta" / Cmd key not working for keyboard shortcuts #123

noahkiss opened this issue Nov 25, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@noahkiss
Copy link

I've tried with Ctrl+Enter on Mac and it works properly. Appears to be a Meta/Cmd button issue.

Based on the below, I think the proper way to handle it in Mac would be to give "Run" (and other commands) proper menu bar support and then map them that way, rather than mapping them in the browser window, which seems to be a shortcoming in mac that doesn't allow Cmd to be registered as a browser window listener.

https://github.com/electron/electron/blob/main/docs/tutorial/keyboard-shortcuts.md

electron/electron#5188 (comment)

Screenshot 2023-11-25 at 9 54 24 AM
@tareqimbasher
Copy link
Owner

Thank you for reporting this. Keyboard shortcuts are actually bound to the native menu bar on all OSes and they are not just bound to the browser window but I might be missing something, I'll take a look!

@tareqimbasher tareqimbasher added the bug Something isn't working label Nov 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants