Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Broken modules imported for Gamma Ray #2590

Open
2 tasks
airvzxf opened this issue Apr 20, 2024 · 0 comments
Open
2 tasks

Bug: Broken modules imported for Gamma Ray #2590

airvzxf opened this issue Apr 20, 2024 · 0 comments

Comments

@airvzxf
Copy link
Contributor

airvzxf commented Apr 20, 2024

Describe the bug

Some functions in the module gamma_ray_transport.py were migrated to gamma_ray_channel.py in TARDIS. These changes are shown in the pull request #2552.

Migrated functions:

  • def calculate_total_decays(inventories, time_delta)
  • def create_isotope_dicts(raw_isotope_abundance, cell_masses)
  • def create_inventories_dict(isotope_dict)

The problem is that these imported modules were not updated in main_gamma_ray_loop.py. It means that some of these functions are imported from gamma_ray_transport rather than gamma_ray_channel.py.

To Reproduce

N/A

Screenshots

N/A

System

  • OS:

    • GNU/Linux
    • macOS
  • Environment (conda list):

Additional context

@airvzxf airvzxf changed the title Bug: Broken modules imported for Gamma Ray. Bug: Broken modules imported for Gamma Ray Apr 20, 2024
@Knights-Templars Knights-Templars self-assigned this Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants