Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formal integral fails in some cases if numba is disabled #2543

Open
andrewfullard opened this issue Mar 11, 2024 · 3 comments
Open

Formal integral fails in some cases if numba is disabled #2543

andrewfullard opened this issue Mar 11, 2024 · 3 comments

Comments

@andrewfullard
Copy link
Contributor

Describe the bug

I_nu[p_idx] = intensity_black_body(nu * z[0], iT)

This causes a quantity conversion error when incorrect units are passed to intensity_black_body.

To Reproduce

Disable Numba, run test_full_formal_integral

@sarthak-dv
Copy link
Contributor

@andrewfullard I'm not able to reproduce this, can you please help.

Whenever I run this test (pytest test_full_formal_integral), it just gets skipped (even after I removed the skip_if~noGPUAvailable decorator). Am I missing something here?

@officialasishkumar
Copy link

Same issue. Trying to run pytest tardis/montecarlo/montecarlo_numba/tests/test_cuda_formal_integral.py::test_full_formal_integral

@andrewfullard
Copy link
Contributor Author

Sorry about that. This is likely an issue the core developers will have to address with GPU-equipped machines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants