Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need test for csvy models that have customized v_inner_boundary #2514

Open
DeerWhale opened this issue Feb 7, 2024 · 0 comments
Open

Need test for csvy models that have customized v_inner_boundary #2514

DeerWhale opened this issue Feb 7, 2024 · 0 comments

Comments

@DeerWhale
Copy link
Contributor

Is your feature request related to a problem? Please describe.
For csvy models that has v_inner_boundary value set to be in between the first and last shells, there were several places that the r_inner and/or v_inner still uses the value at the first shell instead of using the actual inner_boundary (the active shells), the modifications to fix this is in PR #2504

Describe the solution you'd like
However we still need tests that cover these changes. Especially for cases that have customized v_inner_boundary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

No branches or pull requests

1 participant