Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coredump: inspection enhancements #816

Merged
merged 5 commits into from
May 16, 2024

Conversation

elhimov
Copy link
Contributor

@elhimov elhimov commented Apr 4, 2024

  • coredump pack: puts gdb.sh and GDB-extensions into the archive so that it contains everything necessary for convenient coredump inspection
  • coredump inspect: allows archive path as argument (archive should be created with tt coredump pack)
  • coredump inspect: added -s option to specify the location of tarantool sources

Closes #809

@elhimov elhimov requested a review from psergee April 4, 2024 23:01
@elhimov elhimov assigned elhimov and psergee and unassigned elhimov Apr 4, 2024
@elhimov elhimov requested a review from 0x501D April 5, 2024 10:34
@0x501D 0x501D added the full-ci Enables full ci tests label Apr 5, 2024
@elhimov elhimov removed the full-ci Enables full ci tests label Apr 8, 2024
@elhimov elhimov force-pushed the elhimov/gh-809-coredump-inspection-enhancements branch 20 times, most recently from 8d2c413 to db275e7 Compare April 9, 2024 23:35
@elhimov elhimov force-pushed the elhimov/gh-809-coredump-inspection-enhancements branch 6 times, most recently from 0773a64 to 1f02f41 Compare April 11, 2024 05:12
@elhimov elhimov added the full-ci Enables full ci tests label Apr 11, 2024
@elhimov elhimov force-pushed the elhimov/gh-809-coredump-inspection-enhancements branch from 1f02f41 to 620ba1e Compare April 12, 2024 08:42
Copy link
Member

@0x501D 0x501D left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@psergee psergee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the patch!

cli/coredump/coredump.go Outdated Show resolved Hide resolved
cli/coredump/coredump.go Outdated Show resolved Hide resolved
cli/coredump/coredump.go Outdated Show resolved Hide resolved
cli/coredump/coredump.go Outdated Show resolved Hide resolved
cli/coredump/coredump.go Outdated Show resolved Hide resolved
cli/coredump/coredump.go Outdated Show resolved Hide resolved
cli/coredump/coredump.go Outdated Show resolved Hide resolved
cli/coredump/coredump.go Outdated Show resolved Hide resolved
cli/coredump/coredump.go Outdated Show resolved Hide resolved
test/integration/coredump/test_coredump.py Show resolved Hide resolved
@elhimov elhimov force-pushed the elhimov/gh-809-coredump-inspection-enhancements branch 3 times, most recently from f1ec6a5 to d4bab4d Compare May 13, 2024 08:30
Copy link
Collaborator

@psergee psergee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@psergee psergee force-pushed the elhimov/gh-809-coredump-inspection-enhancements branch from d4bab4d to 64ae859 Compare May 16, 2024 08:13
@elhimov elhimov force-pushed the elhimov/gh-809-coredump-inspection-enhancements branch 3 times, most recently from 201264a to ec1fd36 Compare May 16, 2024 09:53
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
- coredump pack: puts gdb.sh and GDB-extensions into the archive so
  that it contains everything necessary for convenient coredump
  inspection
- coredump inspect: allows archive path as argument (archive should be
  created with 'tt coredump pack')
- coredump inspect: added -s option to specify the location of tarantool
  sources

Closes #809
@elhimov elhimov force-pushed the elhimov/gh-809-coredump-inspection-enhancements branch from ec1fd36 to ba1249b Compare May 16, 2024 10:15
@psergee psergee merged commit 7efbc4e into master May 16, 2024
22 of 24 checks passed
@psergee psergee deleted the elhimov/gh-809-coredump-inspection-enhancements branch May 16, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
full-ci Enables full ci tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tt coredump inspection enhancements
3 participants