Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring of the queue drivers tests structure #112

Open
LeonidVas opened this issue Feb 28, 2020 · 3 comments
Open

Refactoring of the queue drivers tests structure #112

LeonidVas opened this issue Feb 28, 2020 · 3 comments
Labels
code health Improve code readability, simplify maintenance and so on

Comments

@LeonidVas
Copy link
Contributor

LeonidVas commented Feb 28, 2020

Now:
Many tests of queue drivers have duplicated code
Wish:
Have some common tests for drivers (remove duplicate code)

Add full testing of a driver API for limfifottl

@LeonidVas
Copy link
Contributor Author

The test case should be either referenced from a certail test file (like 020-fifottl.t) or it should be obvious from names that certain part of cases is in a separate file (say, ddd-driver_api.t).
#106 (comment)

@LeonidVas LeonidVas self-assigned this Feb 28, 2020
@rybakit
Copy link
Contributor

rybakit commented Feb 28, 2020

Have some common tests for drivers (remove duplicate code)

Just a remark, in my library I went a bit further and divided the common tests into non-TTL and TTL-only tests, so I can easily combine them depending on the queue type.

@LeonidVas
Copy link
Contributor Author

Have some common tests for drivers (remove duplicate code)

Just a remark, in my library I went a bit further and divided the common tests into non-TTL and TTL-only tests, so I can easily combine them depending on the queue type.

I like the way you think

@LeonidVas LeonidVas added backlog Issues for upcoming releases (to be done soon) code health Improve code readability, simplify maintenance and so on labels Dec 15, 2020
@Totktonada Totktonada removed backlog Issues for upcoming releases (to be done soon) prio3 labels Dec 23, 2021
@LeonidVas LeonidVas removed their assignment Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code health Improve code readability, simplify maintenance and so on
Projects
None yet
Development

No branches or pull requests

4 participants