Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add availability to hide spinner #661

Open
hackallcode opened this issue Nov 10, 2021 · 6 comments
Open

Add availability to hide spinner #661

hackallcode opened this issue Nov 10, 2021 · 6 comments
Labels
bug Something isn't working

Comments

@hackallcode
Copy link

In GitHub Actions on pack stage I have a spinner that makes such logs:

   • Building base image myapp-build

|
/
-
\
|
/
-
\
|
/
-
\
|

So, I want to disable the spinner in CI. Let's add a flag to do it.

@Totktonada
Copy link
Member

Whether you'll be okay if we'll just fix its displaying? Or it looks so, when you write the log to a file?

Seems similar to #627.

@hackallcode
Copy link
Author

It's not similar to #627.

You can just fix displaying, yes. For example, if the console doesn't support \r then hide spinner, but if supports then show it.

GH Actions doesn't support \r, so we can see hundreds of spinner lines instead of one line.

@NickVolynkin
Copy link
Contributor

NickVolynkin commented Nov 11, 2021

Could it just check if the shell is non-interactive and turn off the spinner?

@hackallcode
Copy link
Author

If it works in GH Actions, it's ok

@vasiliy-t
Copy link

same here, really annoying
image

@filonenko-mikhail
Copy link

it's runes

@Totktonada Totktonada added bug Something isn't working teamE labels Nov 30, 2021
@TarantoolBot TarantoolBot removed the teamE label Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

6 participants