Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax highliting in code mode #41

Open
dinya opened this issue May 14, 2019 · 4 comments · Fixed by #109
Open

Syntax highliting in code mode #41

dinya opened this issue May 14, 2019 · 4 comments · Fixed by #109

Comments

@dinya
Copy link

dinya commented May 14, 2019

Dear @taqueci

Thanks for plugin. It is very nice.

What about to add the Markdown/Textile syntax highliting in code mode?

See for example:

  1. https://github.com/gjroelofs/redmine_codemirror
  2. https://github.com/Lichtbit/redmine_sublime_markdown_codemirror
@taqueci
Copy link
Owner

taqueci commented May 18, 2019

Hi @dinya

I am analyzing the implementation of both the plugins, but it's difficult for me. 😱
Please don't get your hopes up.

@martincizek
Copy link
Contributor

FYI - we have solved this, it's connected with slight format processing redesign / refactoring that allows more further improvements like macro support. Will submit a PR soon, stay tuned! :-)

@dinya
Copy link
Author

dinya commented Oct 29, 2020

@martincizek any news?

martincizek added a commit to orchitech/redmine_wysiwyg_editor that referenced this issue Nov 6, 2020
…rns at the right place. Move code block processing to this plugin. Resolve taqueci#41.
@martincizek
Copy link
Contributor

martincizek commented Nov 6, 2020

@martincizek any news?

I'm not sure if I understood your issue well. I thought it was about code blocks not actually showing the syntax highlighting in visual mode, which is what we resolved. redmine_wysiwyg_editor uses TinyMCE's codesample plugin for code blocks. The integration with codesample plugin works correctly with our changes.

The other two interpretations would be:

  1. You want highlighted markup text source editor for the Redmine texts (i.e. the tab which is currently not affected by redmine_wysiwyg_editor). This is a completely different functionality from redmine_wysiwyg_editor. If it were added, redmine_wysiwyg_editor would then actually act as two plugins :) ... Check out the redmine_codemirror plugin - is it what you're looking for?
  2. You want syntax highlighting when editing code snippets within the visual editor - then it would be about modifying / replacing the functionality of the current TinyMCE's codesample plugin, which highlights syntax in the visual editor component, but not during the actual editing of the code snippet. I can imagine something like codemirror can be used in place of the current codesample plugin now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants